Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some additional types #335

Merged
merged 1 commit into from Feb 21, 2019
Merged

Add some additional types #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions mu-trees/addon/ember-config.js
View file
Open in desktop
Expand Up @@ -25,11 +25,13 @@ export default function generateConfig(name) {
'instance-initializers': { definitiveCollection: 'instance-initializer' },
location: { definitiveCollection: 'main' },
model: { definitiveCollection: 'models' },
modifier: { definitiveCollection: 'main' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
modifier: { definitiveCollection: 'main' },
modifier: { definitiveCollection: 'components' },

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then under collections.components.types you need to add modifier

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on fixing now...

'modifier-manager': { definitiveCollection: 'modifier-managers' },
partial: { definitiveCollection: 'partials' },
renderer: { definitiveCollection: 'main' },
route: { definitiveCollection: 'routes' },
router: { definitiveCollection: 'main' },
'route-map': { definitiveCollection: 'route-map' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this entry is incomplete 🤔, route-map as a collection doesn't exist below...

serializer: { definitiveCollection: 'models' },
service: { definitiveCollection: 'services' },
template: { definitiveCollection: 'components' },
Expand Down