Add component-manager and modifier-manager to default module unification configuration #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Dec 23, 2018
rwjblue
reviewed
Dec 23, 2018
mu-trees/addon/ember-config.js
Outdated
| @@ -18,12 +18,14 @@ export default function generateConfig(name) { | |||
| controller: { definitiveCollection: 'routes' }, | |||
| component: { definitiveCollection: 'components' }, | |||
| 'component-lookup': { definitiveCollection: 'main' }, | |||
| 'component-manager': { definitiveCollection: 'main' }, | |||
There was a problem hiding this comment.
Hmm, I don't think main is right? Shouldn't it be component-managers (assuming src/component-managers/* is where they go)?
There was a problem hiding this comment.
That makes sense yeah. I haven't tested that myself yet though. In https://emberclear.io I've been using main with sparkles.
I can do some testing tomorrow
There was a problem hiding this comment.
so if I just add
'component-manager': { definitiveCollection: 'component-managers' },
I get this error with sparkles:
vendor.js:96748 Uncaught TypeError: Cannot read property 'defaultType' of undefined
at RequireJSRegistry._checkDefaultType (vendor.js:96748)
at RequireJSRegistry._detectModule (vendor.js:96737)
at RequireJSRegistry.has (vendor.js:96757)
at Resolver._serializeAndVerify (vendor.js:66164)
at Resolver.identify (vendor.js:66132)
at Resolver.resolve (vendor.js:66152)
at Class.resolve (vendor.js:97505)
the resolver still doesn't
find the component-manager, so... I needed to add to collections.
There was a problem hiding this comment.
You'd also need to update the defaultType
NullVoxPopuli
changed the title
|
Confirmed working with https://emberclear.io |
cibernox
approved these changes
Dec 24, 2018
rwjblue
approved these changes
Dec 24, 2018
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be default, yeah?