Fix MU for deeply nested classic components #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a MU app consuming a classic addon that exposes nested components, they seem to work as long there is just one "layer" below, like components/foo/bar.js, but not for deeper layered components, like components/foo/bar/baz.js. This fails when resolving, it somehow thinks bar is a collection, and tries to get the default type from undefined. This throws in the @glimmer/resolver, so before the fallback is even tried.
|
I tried to figure out how to add a test, but didn't really understand how the tests in Also they don't seem to be running in CI at all!? Glad to add some test coverage once I know how! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a MU app consuming a classic addon that exposes nested components, they seem to work as long there is just one "layer" below, like
components/foo/bar.js, but not for deeper layered components, likecomponents/foo/bar/baz.js. This fails when resolving, it somehow thinksbaris a collection, and tries to get the default type from undefined. This throws in the place I changed here, so before the fallback is even tried.