Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Add support for --typescript flag to app and addon blueprints #9972

Merged
merged 16 commits into from
Oct 5, 2022
Merged

[ENHANCEMENT] Add support for --typescript flag to app and addon blueprints #9972

merged 16 commits into from
Oct 5, 2022

Commits on Oct 4, 2022

  1. Add support for --typescript in app/addon blueprint

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    d1a1971 View commit details
    Browse the repository at this point in the history

  2. "Fix" for leaking project instance

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    25b76cb View commit details
    Browse the repository at this point in the history

  3. possible solution for NullProject test issue

    @ef4 @simonihmig
    ef4 authored and simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    d83467f View commit details
    Browse the repository at this point in the history

  4. update unit tests mocking 

    I realize some people love highly-mocked unit tests like these, but IMO they are an extremely poor value for effort. This whole are can only really be profitably tested in a more integration test pattern.
    @ef4 @simonihmig
    ef4 authored and simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    5b0032a View commit details
    Browse the repository at this point in the history

  5. handle optional feature

    @ef4 @simonihmig
    ef4 authored and simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    b25bd03 View commit details
    Browse the repository at this point in the history

  6. Refactor to use existing shouldTransformTypeScript infrastructure 

    `
    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    8f3f5ff View commit details
    Browse the repository at this point in the history

  7. lint:types 

    Co-authored-by: Chris Krycho <hello@chriskrycho.com>
    @simonihmig @chriskrycho
    simonihmig and chriskrycho committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    7c452dc View commit details
    Browse the repository at this point in the history

  8. Add empty comment in router

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    e4e7029 View commit details
    Browse the repository at this point in the history

  9. Add e-c-ts as dependency for addons

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    d0cbbd0 View commit details
    Browse the repository at this point in the history

  10. Use new types from ember-qunit

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    874a920 View commit details
    Browse the repository at this point in the history

  11. Fix warning message

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    66f0e29 View commit details
    Browse the repository at this point in the history

  12. Fix tests

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    8a042cd View commit details
    Browse the repository at this point in the history

  13. Fix stale project

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a8683ad View commit details
    Browse the repository at this point in the history

  14. Fix tests

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    09ada8f View commit details
    Browse the repository at this point in the history

  15. Fix test for test helper

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    85f99a5 View commit details
    Browse the repository at this point in the history

  16. Fix embroider test

    @simonihmig
    simonihmig committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    490e73d View commit details
    Browse the repository at this point in the history