Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Fix contents of addon .gitignore file #9850

Merged

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Apr 10, 2022

Reverts part of #9680.
Closes #9849.

@bertdeblock bertdeblock force-pushed the fix-contents-of-addon-gitignore-file branch from 2bdbbae to edf1558 Compare April 10, 2022 07:01
@bertdeblock bertdeblock changed the base branch from master to release April 10, 2022 07:01
@rwjblue rwjblue added the bug label Apr 11, 2022
@rwjblue rwjblue merged commit e89b8d5 into ember-cli:release Apr 11, 2022
@bertdeblock
Copy link
Contributor Author

@rwjblue Do I also need to make a new PR that targets master? This one targets release. I'm unsure how release fixes are normally done for ember-cli.

@kategengler
Copy link
Member

ember-cli "merges forward" so this should make it to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.gitignore file for newly generated v4.3 addons is incorrect
3 participants