Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 638] Interactive way to create new Ember apps and addons #9824

Merged
merged 1 commit into from Sep 30, 2022

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Mar 16, 2022

RFC PR: emberjs/rfcs#638

Went with inquirer for the following reasons:

  • Development of enquirer seems to have stalled
  • prompts seems nice as well, but inquirer is more populair (based on download and GH star count)
  • inquirer seems to be the most active library at the moment

Result:

Screen.Recording.2022-09-30.at.16.04.50.mov

@bertdeblock
Copy link
Contributor Author

I overlooked some tests, e.g. ember help output, will fix asap!

@NullVoxPopuli
Copy link
Contributor

excited to try this out!

@bertdeblock
Copy link
Contributor Author

Can't seem to figure out why CI is failing at the moment.
It seems this line is the culprit:
https://github.com/ember-cli/ember-cli/blob/master/tests/acceptance/smoke-test-slow.js#L236-L237
It hangs, and thus the timeout is exceeded.
Seems to fail here as well:
https://github.com/ember-cli/ember-cli/runs/5564343698?check_suite_focus=true#step:5:2237

package.json Show resolved Hide resolved
@NullVoxPopuli
Copy link
Contributor

Really excited for this!!! An interactive mode is so clutch for folks new to programming and are extremely intimidated by help screens and cli flags.

(It's also just a nice way to walk folks through stuff)

@bertdeblock
Copy link
Contributor Author

Glad you're excited 😄 I just need to know what to do about #9824 (comment).

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great, thanks for working on it!!

I left a couple inline questions/suggestions, and I think we need at least one test that goes through a full flow "acceptance" / "slow" test that actually runs ember new and enters the values for the prompts (to make sure that things actually work in reality).

lib/tasks/interactive-new.js Outdated Show resolved Hide resolved
lib/tasks/interactive-new.js Outdated Show resolved Hide resolved
@bertdeblock
Copy link
Contributor Author

bertdeblock commented Apr 14, 2022

Addressed the smaller issues, still need to come up with an acceptance test that completes the entire flow.

@bertdeblock
Copy link
Contributor Author

In case anyone is following along, I could use some help writing a full acceptance test where we simulate user input.

@kategengler
Copy link
Member

Discussed in the ember-cli meeting today, we've decided not to block on the interactive testing but hope to add that test coverage later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants