New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC 638] Interactive way to create new Ember apps and addons #9824
[RFC 638] Interactive way to create new Ember apps and addons #9824
Conversation
5e36cb8
to
74ee8f9
Compare
I overlooked some tests, e.g. |
74ee8f9
to
846b285
Compare
excited to try this out! |
Can't seem to figure out why CI is failing at the moment. |
846b285
to
c2d8688
Compare
Really excited for this!!! An interactive mode is so clutch for folks new to programming and are extremely intimidated by help screens and cli flags. (It's also just a nice way to walk folks through stuff) |
Glad you're excited 😄 I just need to know what to do about #9824 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great, thanks for working on it!!
I left a couple inline questions/suggestions, and I think we need at least one test that goes through a full flow "acceptance" / "slow" test that actually runs ember new
and enters the values for the prompts (to make sure that things actually work in reality).
59dc359
to
b6f28f8
Compare
Addressed the smaller issues, still need to come up with an acceptance test that completes the entire flow. |
b6f28f8
to
2c2aa89
Compare
In case anyone is following along, I could use some help writing a full acceptance test where we simulate user input. |
2c2aa89
to
bbac514
Compare
bbac514
to
9f082a0
Compare
9f082a0
to
c6494b2
Compare
Discussed in the ember-cli meeting today, we've decided not to block on the interactive testing but hope to add that test coverage later. |
c6494b2
to
f8534ab
Compare
RFC PR: emberjs/rfcs#638
Went with
inquirer
for the following reasons:enquirer
seems to have stalledprompts
seems nice as well, butinquirer
is more populair (based on download and GH star count)inquirer
seems to be the most active library at the momentResult:
Screen.Recording.2022-09-30.at.16.04.50.mov