Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from octane template lint config to recommended #9558

Merged
merged 1 commit into from
May 28, 2021

Conversation

bmish
Copy link
Member

@bmish bmish commented May 27, 2021

ember-template-lint v3 promoted the octane config (now deprecated) to be recommended.

https://github.com/ember-template-lint/ember-template-lint/blob/master/CHANGELOG.md#v300-2021-03-02

@bmish
Copy link
Member Author

bmish commented May 27, 2021

@rwjblue if possible, let's get this into the upcoming release, so we aren't using the deprecated/to-be-deleted config anymore.

@rwjblue
Copy link
Member

rwjblue commented May 27, 2021

ya, good idea

@bmish - Can you target beta branch with this PR? I think you'll have to update the PR target to beta, then rebase out all except your new commit, then force push to your branch.

@bmish bmish changed the base branch from master to beta May 27, 2021 21:04
@bmish bmish force-pushed the template-lint-recommended branch from f009b61 to 6ac4004 Compare May 27, 2021 21:08
@bmish
Copy link
Member Author

bmish commented May 27, 2021

@rwjblue switched to beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants