Enable Embroider by default for new projects #9495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Mar 25, 2021
rwjblue
changed the title
thoov
added a commit
to thoov/embroider
that referenced
this pull request
Mar 26, 2021
Fixes: embroider-build#681 & embroider-build#676 Ember-cli's test suite caught an issue with windows support when trying to enable embroider by default (ember-cli/ember-cli#9495). After this change I was able to successfully do a build with a new Ember app.
|
Will need to have: embroider-build/embroider#742 landed and released |
rwjblue
pushed a commit
to thoov/embroider
that referenced
this pull request
Mar 29, 2021
Fixes: embroider-build#681 & embroider-build#676 Ember-cli's test suite caught an issue with windows support when trying to enable embroider by default (ember-cli/ember-cli#9495). After this change I was able to successfully do a build with a new Ember app.
thoov
added a commit
to thoov/embroider
that referenced
this pull request
Mar 29, 2021
Fixes: embroider-build#681 & embroider-build#676 Ember-cli's test suite caught an issue with windows support when trying to enable embroider by default (ember-cli/ember-cli#9495). After this change I was able to successfully do a build with a new Ember app.
thoov
force-pushed
the
enable-embroider-default
branch
from
c660901
to
4fc54d5
Compare
|
@rwjblue this is good to go now |
|
🎉🥁🙌👏 |
kellyselden
reviewed
Mar 31, 2021
| "@embroider/compat": "^0.37.0", | ||
| "@embroider/core": "^0.37.0", | ||
| "@embroider/webpack": "^0.37.0<% } %>", | ||
| "@embroider/compat": "^0.39.1", |
There was a problem hiding this comment.
Shouldn't this be 1.0 if we are now official?
There was a problem hiding this comment.
Not necessarily (we have other non-1.0.0 things in the blueprint, e.g. ember-maybe-import-regenerator), but we absolutely are working towards a 1.0.0. Look out for a meta issue on Embroider repo soon for that. I'd like to get that landed by the time we do 3.28.0 (an LTS release).
There was a problem hiding this comment.
Cross linking the issue you made to track that also: embroider-build/embroider#761
|
As much as I am excited about Embroider (having used and contributed to it), I am nevertheless quite surprised by this move here! Given how much this changes the underlying build infrastructure, wouldn't an RFC be required here? Mainly for two reasons:
Some examples for these points off the top of my head:
Tl;dr: I feel this is premature and would require a thorough transition path in an RFC! 🤷♂️ /cc @ef4 |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New apps generated via
ember newwill now default to use Embroider's build system.