Prevent window.Ember deprecation on Ember 3.27+. #9490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
approved these changes
Mar 19, 2021
Accessing `window.Ember` (e.g. without importing) will issue a deprecation in Ember 3.27 and higher, and ultimately removed in Ember 4.
rwjblue
force-pushed
the
avoid-globals-deprecation
branch
from
6252533
to
cd0fa8b
Compare
snewcomer
pushed a commit
to kimroen/ember-cli-autoprefixer
that referenced
this pull request
Nov 22, 2021
…#78) * Update ember-auto-import to fix CI * Switch ember-cli-template-lint -> ember-template-lint for Ember v4 compatibility * Ensure `ember-classic` ember-try scenario uses Ember 3.28.x * Upgrade ember-qunit to v5 * Use Ember CLI v3.28.4 for Ember v4 scenarios For more info see ember-cli/ember-cli#9490
chriskrycho
pushed a commit
to tracked-tools/tracked-toolbox
that referenced
this pull request
Jun 13, 2022
(cherry picked from commit 9a44d74)
chriskrycho
pushed a commit
to tracked-tools/tracked-toolbox
that referenced
this pull request
Jun 13, 2022
(cherry picked from commit 9a44d74)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing
window.Ember(e.g. without importing) will issue a deprecation in Ember 3.27 and higher, and ultimately removed in Ember 4.