Refactor getPort to only check required port #9480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portfinder library gets port as follows --
getPort({:port 0})
:getPort({:port <non-zero>})
:<non-zero>
and upper limit (which is40000
)getPort({:port <lower-limit>, :stopPort <upper-limit>})
<lower-limit>
and<upper-limit>
In the ember script, we should only check for the specified port and not check for a range.
Hence, for a non-zero required port, we check for an open port in the range --
[portNum, portNum]
So if this port is not available, then
getPort
will give an exception.If the requested port is less than
1024
, then the reason for port being unavailable can be that --So we set appropriate error message based on the requested port.