Add .*/ to eslint ignore
#9456
Merged
Add .*/ to eslint ignore
#9456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`!.*` was added to ensure js-based config files are linted (#8070) However, this was probably too broad. An unintended consequence of that change was that the `.git` directory is now linted by eslint. The easiest way to observe this is to create a branch with `.js` in the name: ```shell git checkout -b "foo.js" yarn lint:js ``` This will now error since git created a file called `foo.js` in `.git` to maintain the metadata for this branch, but the file does not contain valid JavaScript. In addition to these error scenarios, it causes unnecessary file scans. There are probably other caches by other tools other than git that could cause problems here as well.
kellyselden
approved these changes
Feb 24, 2021
wagenet
approved these changes
Feb 24, 2021
|
Thank you! |
|
@chancancode should this also be added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!.*was added to ensure js-based config files are linted (#8070)However, this was probably too broad. An unintended consequence of that change was that the
.gitdirectory is now linted by eslint. The easiest way to observe this is to create a branch with.jsin the name:git checkout -b "foo.js" yarn lint:jsThis will now error since git created a file called
foo.jsin.gitto maintain the metadata for this branch, but the file does not contain valid JavaScript.In addition to these error scenarios, it causes unnecessary file scans. There are probably other caches by other tools other than git that could cause problems here as well.