Fix how MU blueprints fetches ember-source
#8432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the initial implementation of #8323.
In some cases, the
ember-source
version was assigned empty because the promise was not fulfilled yet.I think the test suite did not fail because it may have been using a local
ember-source
version.Making
locals
to return a Promise looks correct based on thelocals
documentation.I added an assertion that failed previously.
Initially, I realized about this error when adding the feature to the
octane-blueprint
(the octane blueprints follow this structure), and this error has also been reported at https://github.com/ember-cli/ember-cli/pull/8424/files#r256792430 and #8431