Update ember-welcome-page usage to angle brackets

[locks]

No description provided.

[rwjblue]

Need to update the test fixtures here:

ember-cli/tests/fixtures/addon/yarn/tests/dummy/app/templates/application.hbs

Line 2 in 94a6782

{{welcome-page}}

ember-cli/tests/fixtures/app/yarn/app/templates/application.hbs

Line 2 in 94a6782

{{welcome-page}}

[stefanpenner]

fancy

[ppcano]

The ember-welcome-page project should also change its copy:

remove the <WelcomePage /> component from your application.hbs

Note: MU apps defines the template at ui/routes/application/template.hbs.

[rwjblue]

Great point @ppcano! Mind tweaking the addon to change the copy? With a stretch goal of possibly keeping {{welcome-page}} displayed for Ember < 3.4 and detecting MU to display the correct location...

[ppcano]

ember-cli/ember-welcome-page#124 is a PR for the mentioned addon changes

[rwjblue]

ping @locks - mind updating the fixtures I linked to?

[locks]

On it!

[locks]

Failing test on node 6:

not ok 1329 Acceptance: smoke-test ember test wasm
      Running: node_modules/ember-cli/bin/ember build in: /home/travis/build/ember-cli/ember-cli/tmp/some_cool_app_clone-lah7ZT3o.tmp

🤔

[rwjblue]

ember-cli/ember-welcome-page#124 updates the messaging to use angle bracket invocation as well, it is released in v4.0.0.