Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the module path for MU non-acceptance tests #8379

Merged
merged 1 commit into from Jan 23, 2019

Conversation

ppcano
Copy link
Contributor

@ppcano ppcano commented Jan 22, 2019

Closes #8363

It set correctly the module path of the MU tests; given the following test file /src/utils/unit-test:

Before -> $packageName/tests/utils/unit-test
Now -> $packageName/src/utils/unit-test

The fix solves relative imports within the test file. The PR includes an unit test:

import { module, test } from 'qunit';
import stringFn from './string';

 module('Unit | Utility | string', function() {
  ...
 });

@rwjblue rwjblue merged commit 94a6782 into ember-cli:master Jan 23, 2019
@rwjblue
Copy link
Member

rwjblue commented Jan 23, 2019

Awesome, thank you!

ppcano referenced this pull request Jan 24, 2019
In MU apps, exclude TS test files from the app JS file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In MU apps, relative imports in a test file fails
2 participants