New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include addon styles for MU apps #8289
Conversation
@patricklx I think the commit 183269e in this PR fixes the same issue as #8146. I will continue investigating because I think the problem is in the pre-processor logic. |
e8df6d8
to
32e53b7
Compare
6c65235
to
c743abb
Compare
anything left on this? |
No, as far as I know. |
@NullVoxPopuli who can finally review or merge this one? This PR fixes a few reported bugs and change slightly the current MU preprocess logic. |
I don't remember if I've tested it, but, @ppcano, this repo should work when pointed at your branch: https://github.com/NullVoxPopuli/test-ember-paper-with-module-unification 🤷♂️ can't test it out atm. |
sorry, I don't know enough about MU to be able to review this properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor changes needed here (to make future debugging of this pipeline easier), but overall looks great!
The previous `preprocessCss` implementation forced to build styles on the `assets` folder
Caused by the rebase
c743abb
to
197aabe
Compare
@rwjblue Done |
Thx, @ppcano! 🙇 |
This change fixes the CSS stylesheets that require importing from addons feature for MU applications importing styles from classic addons.
ember-styleguide
.MU applications will now execute
preprocessCss
onpackageStyles
like Classic applications and it removes the existingpreprocessCss
call of theprocessSrc
method.I am not sure this is the correct implementation but this implementation looks more natural and it enables the
specifying custom output paths works properly
test at 6c65235 (cc @twokul).A similar issue was reported at #8197 where MU applications executed
preprocessTemplates
twice onprocessSrc
andprocessTemplates
.Closes #8134, #8133, #8146