Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Be more explicit about page-title being a helper rather than a component #10355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ynotdraw
Copy link

With embroider, you need to be more explicit on differentiating components versus helpers. By wrapping this in ( and ), we are explicitly telling it that this is a helper rather than a component. Even though embroider may not be adopted everywhere yet, I think getting folks in the habit of doing this now may make their migration path a lot easier.

@NullVoxPopuli
Copy link
Contributor

thank you!!!

@ynotdraw ynotdraw force-pushed the update-helper-in-app-blueprint branch from acf4f5d to bb1e725 Compare August 28, 2023 15:11
This was referenced Aug 28, 2023
@bertdeblock
Copy link
Contributor

@kategengler
Copy link
Member

The parens aren't necessary with embroider. @NullVoxPopuli Do you think this is relevant?

@NullVoxPopuli
Copy link
Contributor

It's needed whet staticComponents: true isn't set in ember-cli-build.js, because there is no way to statically differentiate {{page-title}} from component or helper.

I don't agree that it should be a part of the blueprint though, because (imo!!), the blueprint should be static-all-the-things-first, rather than partially migrated static-all-the-things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants