[BUGFIX] Do not try to wire up Testem unless a test framework is dete… #10314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted -- this is for legacy compat -- modern libraries, such as ember-qunit, call hookIntoTestFramework themselves, because it has better knowledge of when Testem needs to be configured Update test to reflect changes to internal default-packager files
|
looking like floating deps (DT) caused the failures? |
|
Failure in CI is apparently caused by #10301 |
|
The discussion on the meeting was to skip that failing test in Node 14 👍 |
ef4
reviewed
Jul 27, 2023
tests/acceptance/new-test.js
Outdated
| @@ -625,7 +625,7 @@ describe('Acceptance: ember new', function () { | |||
| checkFileWithEmberCLIVersionReplacement(fixturePath, 'tests/dummy/config/ember-cli-update.json'); | |||
| }); | |||
|
|
|||
| it('app + typescript', async function () { | |||
| it.skip('app + typescript', async function () { | |||
There was a problem hiding this comment.
The intention was to skip them in node 14, not skip them in every node.
There was a problem hiding this comment.
I added a node check in the latest commit 🥳
(I had tried checking NODE_VERSION on the env, but our test infra doesn't expose that, and I didn't think it made sense to mess with the test infra rn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cted -- this is for legacy compat -- modern libraries, such as ember-qunit, call hookIntoTestFramework themselves, because it has better knowledge of when Testem needs to be configured
Update test to reflect changes to internal default-packager files
Backport of #10300