New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLEANUP] Update blueprint ignore files #10229
[CLEANUP] Update blueprint ignore files #10229
Conversation
@@ -1,23 +1,13 @@ | |||
# unconventional js | |||
/blueprints/*/files/ | |||
/vendor/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed from the default blueprint in #10050.
Theoretically, should not be needed anymore in new Ember apps and addons.
|
||
# compiled output | ||
/dist/ | ||
/tmp/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used anymore in new Ember apps.
/tmp/ | ||
|
||
# dependencies | ||
/node_modules/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint ignores node_modules
by default:
https://eslint.org/docs/latest/use/configure/ignore#the-eslintignore-file
|
||
# misc | ||
/coverage/ | ||
!.* | ||
.*/ | ||
.eslintcache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't lint its own cache file.
|
||
# ember-try | ||
/.node_modules.ember-try/ | ||
/npm-shrinkwrap.json.ember-try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not .js
or .ts
files, so no need to list these.
|
||
# ember-try | ||
/.node_modules.ember-try/ | ||
/npm-shrinkwrap.json.ember-try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not picked up by Prettier, so no need to list these.
@@ -1,20 +1,14 @@ | |||
# See https://help.github.com/ignore-files/ for more about ignoring files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link doesn't work anymore.
/.eslintcache | ||
/connect.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never seen this being created. I assume it's something that was needed a long time ago.
/coverage/ | ||
/libpeerconnection.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never seen this being created. I assume it's something that was needed a long time ago.
|
||
# dependencies | ||
/node_modules/ | ||
|
||
# misc | ||
/.env* | ||
/.pnp* | ||
/.sass-cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apps or addons that use SASS, should include this explicitly.
Closes #10063.