Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Update blueprint ignore files #10229

Merged

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Mar 30, 2023

Closes #10063.

@bertdeblock bertdeblock self-assigned this Mar 30, 2023
@@ -1,23 +1,13 @@
# unconventional js
/blueprints/*/files/
/vendor/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed from the default blueprint in #10050.
Theoretically, should not be needed anymore in new Ember apps and addons.


# compiled output
/dist/
/tmp/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used anymore in new Ember apps.

/tmp/

# dependencies
/node_modules/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# misc
/coverage/
!.*
.*/
.eslintcache
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't lint its own cache file.


# ember-try
/.node_modules.ember-try/
/npm-shrinkwrap.json.ember-try
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not .js or .ts files, so no need to list these.


# ember-try
/.node_modules.ember-try/
/npm-shrinkwrap.json.ember-try
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not picked up by Prettier, so no need to list these.

@@ -1,20 +1,14 @@
# See https://help.github.com/ignore-files/ for more about ignoring files.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link doesn't work anymore.

/.eslintcache
/connect.lock
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen this being created. I assume it's something that was needed a long time ago.

/coverage/
/libpeerconnection.log
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen this being created. I assume it's something that was needed a long time ago.


# dependencies
/node_modules/

# misc
/.env*
/.pnp*
/.sass-cache
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apps or addons that use SASS, should include this explicitly.

@bertdeblock bertdeblock mentioned this pull request Mar 30, 2023
32 tasks
@kategengler kategengler merged commit 0407a30 into ember-cli:master Apr 5, 2023
11 checks passed
@bertdeblock bertdeblock changed the title Update blueprint ignore files [CLEANUP] Update blueprint ignore files Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up ignore files in app and addon blueprints
2 participants