[INTERNAL] Fix tests related to generating blueprints using a path instead of a name #10092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
force-pushed
the
fix-generating-blueprints-using-a-path-tests
branch
2 times, most recently
from
fdc9c1c
to
a95932d
Compare
bertdeblock
commented
Dec 7, 2022
bertdeblock
force-pushed
the
fix-generating-blueprints-using-a-path-tests
branch
from
a95932d
to
75b0299
Compare
kategengler
approved these changes
Dec 14, 2022
bertdeblock
force-pushed
the
fix-generating-blueprints-using-a-path-tests
branch
2 times, most recently
from
6cd246a
to
18a4a8b
Compare
bertdeblock
force-pushed
the
fix-generating-blueprints-using-a-path-tests
branch
from
18a4a8b
to
617e5c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were added in #9387, but they actually pass with and without the added code, which makes them unreliable and makes it hard to know if the added code actually does what it's supposed to.
This was uncovered when reviewing #10091.