Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Update Prettier config in blueprints to only use single quotes for .js and .ts files #10062

Merged

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Oct 24, 2022

This updates the .prettierrc.js file so that it only applies the singleQuote config to .js (and .ts) files. This has the benefit that other file types will still use the default Prettier settings and apps no longer have to add config overrides to ensure that.

Closes #10061

This updates the `.prettierrc.js` file so that it only applies the singleQuote config to `.js` (and `.ts`) files. This has the benefit that other file types will still use the default Prettier settings and apps no longer have to add config overrides to ensure that.
@Windvis Windvis force-pushed the feat/update-blueprint-prettier-config branch from 7237d4c to 3dc6e5a Compare October 29, 2022 19:02
@bertdeblock bertdeblock merged commit b075b2e into ember-cli:master Oct 30, 2022
@bertdeblock bertdeblock changed the title [ENHANCEMENT] Update the Prettier config in the blueprints [ENHANCEMENT] Update the Prettier config in the blueprints to only use single quotes for .js and .ts files Oct 30, 2022
@Windvis Windvis deleted the feat/update-blueprint-prettier-config branch October 30, 2022 08:14
@bertdeblock bertdeblock changed the title [ENHANCEMENT] Update the Prettier config in the blueprints to only use single quotes for .js and .ts files [ENHANCEMENT] Update Prettier config in blueprints to only use single quotes for .js and .ts files Nov 5, 2022
@jelhan
Copy link
Contributor

jelhan commented Jan 22, 2023

Thanks a lot for this change! This will ease adoption of Prettier for Handlebars, YAML, Markdown and others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak the Prettier config so it only applies to JS files by default
4 participants