Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Conditionally apply ESLint parser options in app and addon blueprints #10054

Merged

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Oct 18, 2022

This removes the parserOptions options that are not relevant for the `@typescript-eslint/parser' parser.

More information about the available options: https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/parser#configuration

Fixes #10046

@Windvis Windvis force-pushed the fix/typescript-eslint-parser-options branch from 49b0f2e to 861b814 Compare October 18, 2022 19:11
@Windvis Windvis marked this pull request as ready for review October 18, 2022 19:11
This removes the `parserOptions` options that are not relevant for the `@typescript-eslint/parser' parser.

More information about the available options: https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/parser#configuration
@Windvis Windvis force-pushed the fix/typescript-eslint-parser-options branch from 861b814 to 32fe0dd Compare October 27, 2022 10:00
Copy link
Contributor

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bertdeblock could you kick off CI and review?

@Windvis Windvis changed the title Conditionally apply eslint parserOptions [ENHANCEMENT] Conditionally apply eslint parserOptions Oct 29, 2022
@bertdeblock bertdeblock merged commit 29ad3bc into ember-cli:master Oct 29, 2022
@Windvis Windvis deleted the fix/typescript-eslint-parser-options branch October 29, 2022 18:40
@bertdeblock bertdeblock changed the title [ENHANCEMENT] Conditionally apply eslint parserOptions [ENHANCEMENT] Conditionally apply ESLint parser options in app and addon blueprints Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parser options used when using the @typescript-eslint/parser parser
3 participants