Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node has support for packages that export files in ES module syntax. See module packages in the node documentation.
This feature doesn't quite work with ember addons due to in-addon files being loaded:
require
Relative
require
s can be made to work with conditional exports, but even that would require addon authors to write those files in commonjs format.Absolute requires cannot be made to work unless the file loaded has a
cjs
suffix.This PR makes it possible to write ember addons that opt in to ES module syntax. The support is imperfect since config/environment.js still has to be in commonjs format, so in practice addon authors need to write: