[ENHANCEMENT] Remove the config/environment.js file from the addon blueprint
#10049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
force-pushed
the
remove-config-environment-file-from-addon-blueprint
branch
from
cb69e7d
to
fa97d4e
Compare
rwjblue
approved these changes
Oct 19, 2022
bertdeblock
force-pushed
the
remove-config-environment-file-from-addon-blueprint
branch
from
fa97d4e
to
04ad46a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
config/environment.jsfile, it sometimes happens that addon authors mistakingly use this file to configure the dummy app - an unwanted side effect of this is that, the configuration also ends up in the consuming appThis doesn't mean that the file is not supported anymore of course, it's just not included by default.
Resolves part of #7486 (comment).