Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Use concurrently instead of npm-run-all in app blueprint #10022

Merged
merged 1 commit into from Sep 28, 2022
Merged

[ENHANCEMENT] Use concurrently instead of npm-run-all in app blueprint #10022

merged 1 commit into from Sep 28, 2022

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Sep 17, 2022 •
edited

npm-run-all hasn't received any updates in the past 4 years. concurrently seems to be a popular alternative.

We also use concurrently in the v2 addon blueprint: embroider-build/addon-blueprint#37.

Closes #9966.

@bertdeblock bertdeblock self-assigned this Sep 17, 2022
@bertdeblock bertdeblock changed the title Use concurrently instead of npm-run-all in app blueprint [ENHANCEMENT] Use concurrently instead of npm-run-all in app blueprint Sep 17, 2022
@bertdeblock bertdeblock force-pushed the use-concurrently-instead-of-npm-run-all-in-app-blueprint branch from c090696 to fe5f8da Compare September 21, 2022 08:11
@bertdeblock bertdeblock force-pushed the use-concurrently-instead-of-npm-run-all-in-app-blueprint branch from fe5f8da to f49a9c8 Compare September 28, 2022 17:47
@bertdeblock bertdeblock force-pushed the use-concurrently-instead-of-npm-run-all-in-app-blueprint branch from f49a9c8 to 62f309e Compare September 28, 2022 18:36
@bertdeblock bertdeblock merged commit 5c26dc2 into ember-cli:master Sep 28, 2022
@jaredgalanis jaredgalanis mentioned this pull request Dec 8, 2022
Merged
@NullVoxPopuli
Copy link
Contributor

looks like we may need npm-run-all for just the test script, since lint && test && try:each need to run serially, and concurrently doesn't do serial execution (on purpose)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

@ef4 ef4 ef4 approved these changes

Assignees

@bertdeblock bertdeblock

Labels
ember-new-output enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace npm-run-all with concurrently in blueprints?
4 participants
@bertdeblock @NullVoxPopuli @locks @ef4