Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trap unhandled failures #10018

Merged
merged 1 commit into from Sep 14, 2022
Merged

Trap unhandled failures #10018

merged 1 commit into from Sep 14, 2022

Commits on Sep 13, 2022

  1. Trap unhandled failures 

    If an exception escapes from the main `cli()` function, we don't handle it. On Node < 16 that results in a successful process exit code even though the process has crashed.

On Node >= 16 this was not a bug because of the stricter handling of unhandled promise rejections.

You can demonstrate the bug by putting a string in `ember-addon.paths` in your app's package.json file. (It's supposed to be an array, and will cause a crash.)
    @ef4
    ef4 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    5e83301 View commit details
    Browse the repository at this point in the history