Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Disable prototype extensions by default in app blueprint #10017

Merged
merged 1 commit into from Oct 3, 2022
Merged

[ENHANCEMENT] Disable prototype extensions by default in app blueprint #10017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion blueprints/addon/additional-package.json
View file
Open in desktop
Expand Up @@ -7,7 +7,6 @@
},
"devDependencies": {
"@embroider/test-setup": "^1.8.3",
"ember-disable-prototype-extensions": "^1.1.3",
"ember-source-channel-url": "^3.0.0",
"ember-try": "^2.0.0"
},
Expand Down
1 change: 1 addition & 0 deletions blueprints/app/files/config/environment.js
View file
Open in desktop
Expand Up @@ -7,6 +7,7 @@ module.exports = function (environment) {
rootURL: '/',
locationType: 'history',
EmberENV: {
EXTEND_PROTOTYPES: false,
FEATURES: {
// Here you can enable experimental features on an ember canary build
// e.g. EMBER_NATIVE_DECORATOR_SUPPORT: true
Expand Down
1 change: 0 additions & 1 deletion tests/fixtures/addon/defaults-travis/package.json
View file
Open in desktop
Expand Up @@ -44,7 +44,6 @@
"ember-cli-inject-live-reload": "^2.0.2",
"ember-cli-sri": "^2.1.1",
"ember-cli-terser": "^4.0.2",
"ember-disable-prototype-extensions": "^1.1.3",
"ember-load-initializers": "^2.1.2",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-page-title": "^7.0.0",
Expand Down
1 change: 0 additions & 1 deletion tests/fixtures/addon/defaults/package.json
View file
Open in desktop
Expand Up @@ -44,7 +44,6 @@
"ember-cli-inject-live-reload": "^2.1.0",
"ember-cli-sri": "^2.1.1",
"ember-cli-terser": "^4.0.2",
"ember-disable-prototype-extensions": "^1.1.3",
"ember-load-initializers": "^2.1.2",
"ember-page-title": "^7.0.0",
"ember-qunit": "^5.1.5",
Expand Down
1 change: 0 additions & 1 deletion tests/fixtures/addon/yarn/package.json
View file
Open in desktop
Expand Up @@ -44,7 +44,6 @@
"ember-cli-inject-live-reload": "^2.1.0",
"ember-cli-sri": "^2.1.1",
"ember-cli-terser": "^4.0.2",
"ember-disable-prototype-extensions": "^1.1.3",
"ember-load-initializers": "^2.1.2",
"ember-page-title": "^7.0.0",
"ember-qunit": "^5.1.5",
Expand Down
14 changes: 0 additions & 14 deletions tests/unit/blueprints/addon-test.js
View file
Open in desktop
Expand Up @@ -124,19 +124,6 @@ describe('blueprint - addon', function () {
expect(json.keywords).to.deep.equal(['ember-addon']);
});

it('overwrites any version of `ember-disable-prototype-extensions`', function () {
let output = blueprint.updatePackageJson(
JSON.stringify({
devDependencies: {
'ember-disable-prototype-extensions': '1.1.2',
},
})
);

let json = JSON.parse(output);
expect(json.devDependencies['ember-disable-prototype-extensions']).to.equal('^1.1.3');
});

it('adds `scripts.test:all`', function () {
let output = blueprint.updatePackageJson(
JSON.stringify({
Expand Down Expand Up @@ -176,7 +163,6 @@ describe('blueprint - addon', function () {
);

let json = JSON.parse(output);
delete json.devDependencies['ember-disable-prototype-extensions'];
delete json.devDependencies['eslint-plugin-node'];
delete json.devDependencies['ember-try'];
delete json.devDependencies['ember-source-channel-url'];
Expand Down