Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update glob to v8 #10015

Merged
merged 1 commit into from Sep 13, 2022
Merged

Update glob to v8 #10015

merged 1 commit into from Sep 13, 2022

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Sep 9, 2022 •
edited

Using forward slashes in glob patterns is now required.
More info here: https://github.com/isaacs/minimatch#windows.

@bertdeblock bertdeblock added the dependencies Pull requests that update a dependency file label Sep 9, 2022
@bertdeblock bertdeblock self-assigned this Sep 9, 2022
@bertdeblock bertdeblock mentioned this pull request Sep 9, 2022
Closed
@kellyselden
Copy link
Member

Would it make sense to switch glob packages like fast-glob, if they have better Windows paths support?

@bertdeblock
Copy link
Contributor Author

@kellyselden fast-glob has the same requirement regarding using forward slashes in glob patterns:
https://github.com/mrmlnc/fast-glob#how-to-write-patterns-on-windows

I can still do the switch if you feel fast-glob is better?

@kellyselden
Copy link
Member

In that case, I'm OK with this change. I thought it was a glob exclusive issue.

@bertdeblock bertdeblock merged commit 51b46cc into ember-cli:master Sep 13, 2022
@jaredgalanis jaredgalanis mentioned this pull request Dec 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyselden kellyselden kellyselden approved these changes

Assignees

@bertdeblock bertdeblock

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bertdeblock @kellyselden