Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Make sure newly installed addons are discovered when running ember install #10014

Merged
merged 1 commit into from Sep 18, 2022

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Sep 8, 2022

Running ember install addon-name currently throws the following error:

Install failed. Could not find addon with name: addon-name

This regression seems to have been introduced by #9890, even though the fix in that PR seems logical.

@kellyselden
Copy link
Member

Do you mind targeting the release branch?

@bertdeblock bertdeblock changed the base branch from master to release September 14, 2022 18:37
@bertdeblock
Copy link
Contributor Author

@kellyselden Done!

@simonihmig
Copy link
Contributor

The fix here is needed for #9972, so would appreciate if we could land this soon! 🙏 😀

@csprocket777
Copy link

When using ember-cli to create a new project, it created the project with Ember 3.22. I then upgraded it using ember-cli-update to 4.7.0 and am experiencing this issue. Am I experiencing this because of this upgrade process or is this still present in 4.7.0?

@bertdeblock
Copy link
Contributor Author

When using ember-cli to create a new project, it created the project with Ember 3.22.

Probably because your globally installed version is v3.22?

Am I experiencing this because of this upgrade process or is this still present in 4.7.0?

I don't think this fix has been released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants