Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-classic scenario will stop working soon #9658

Closed
chancancode opened this issue Oct 6, 2021 · 3 comments
Closed

ember-classic scenario will stop working soon #9658

chancancode opened this issue Oct 6, 2021 · 3 comments

Comments

@chancancode
Copy link
Contributor

{
name: 'ember-classic',
env: {
EMBER_OPTIONAL_FEATURES: JSON.stringify({
'application-template-wrapper': true,
'default-async-observers': false,
'template-only-glimmer-components': false,
}),
},
npm: {
ember: {
edition: 'classic',
},
},
},

I believe the classic option is deprecated/removed for 4.0, so we will probably have to pin this scenario to 3.28 or something.

@rwjblue
Copy link
Member

rwjblue commented Oct 6, 2021

I think the best thing to do here, is to also have that scenario pin to ember-source@^3.28.0. For now, addons should still be testing against 3.24 / 3.28; so having a "classic" scenario does seem correct.

@bertdeblock
Copy link
Contributor

Can be closed since #9659 is merged?

@kategengler
Copy link
Member

I think so, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants