Ensure ember-classic ember-try scenario uses Ember 3.x
#9659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
update-ember-classic-scenario
branch
from
de9ef67
to
7f3b65f
Compare
As we approach Ember 4.0.0, we need to help addons ensure that they only test ember-classic's set of optional features when running under 3.x. This updates the default ember-try config to hard code the `ember-classic` scenario to Ember 3.28 (the last 3.x Ember version).
rwjblue
force-pushed
the
update-ember-classic-scenario
branch
from
7f3b65f
to
2e344a2
Compare
bors
added a commit
to rust-lang/crates.io
that referenced
this pull request
Oct 13, 2021
Update dependency ember-cli to v3.28.2 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ember-cli](https://ember-cli.com/) ([source](https://togithub.com/ember-cli/ember-cli)) | [`3.28.1` -> `3.28.2`](https://renovatebot.com/diffs/npm/ember-cli/3.28.1/3.28.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ember-cli/ember-cli</summary> ### [`v3.28.2`](https://togithub.com/ember-cli/ember-cli/releases/v3.28.2) [Compare Source](https://togithub.com/ember-cli/ember-cli/compare/v3.28.1...v3.28.2) ##### Blueprint Changes - [`ember new` diff](https://togithub.com/ember-cli/ember-new-output/compare/v3.28.1...v3.28.2) - [`ember addon` diff](https://togithub.com/ember-cli/ember-addon-output/compare/v3.28.1...v3.28.2) ##### What's Changed - Ensure `ember-classic` ember-try scenario uses Ember 3.x by [`@​rwjblue](https://togithub.com/rwjblue)` in [ember-cli/ember-cli#9659 **Full Changelog**: ember-cli/ember-cli@v3.28.1...v3.28.2 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we approach Ember 4.0.0, we need to help addons ensure that they only test ember-classic's set of optional features when running under 3.x.
This updates the default ember-try config to hard code the
ember-classicscenario to Ember 3.28 (the last 3.x Ember version).Fixes #9658