Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bun support for Ember CLI projects #10444

Open
alakameljebali opened this issue Feb 17, 2024 · 1 comment
Open

Add bun support for Ember CLI projects #10444

alakameljebali opened this issue Feb 17, 2024 · 1 comment

Comments

@alakameljebali
Copy link

Hello Ember CLI team,

I am a fan of your project and I appreciate your work on providing a great command-line interface for Ember.js apps.

I am also using bun.sh, a fast JavaScript runtime and toolkit that includes a bundler, test runner, and npm client. I think bun.sh has some advantages over Node.js, such as speed, elegant APIs, and TypeScript support.

I would like to request a feature to add bun support for Ember CLI projects. This would allow users to run, test, and bundle their Ember.js apps using bun instead of Node.js.

I think this would be beneficial for the Ember.js community, as it would offer more choice and flexibility for developers. It would also showcase the compatibility and interoperability of bun with existing JavaScript tools and frameworks.

I am not sure how difficult or feasible this feature would be, but I hope you will consider it. Thank you for your time and attention.

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Feb 17, 2024

Hello! I would like bun to support ember-cli as well. Bun seems very fast, but in practicality, it hasn't been very easy for any of my tools to adopt (ember-cli included!)

I tried running ember-cli with bun, and ran in to this: oven-sh/bun#5121

I'd also opened this issue: #10371 (so this #10444 may be considered a duplicate of #10371)

imo, it's not so much a feature that ember-cli supports bun, but moreso that bun needs to implement process/EventEmitter correctly 😅 (or declare a good reason why they won't, and then we can move on from there with bun-specific branching or something (but that's kinda gross)) (or, ember-cli removes it's process instanceof EventEmitter check, and either work-around the issue or do something simpler during initialization.

In particular, there is this code within ember-cli:

if (outerProcess instanceof EventEmitter === false) {

I don't know why we need to capture an outerProcess. ember-cli has been around since the Node 0.x days, so it's possible that none of this code is needed in modern node, and by removing code that not needed by Node < 16, maybe we'll accidentally be compatible with bun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants