Skip to content

Commit

Permalink
Merge pull request #10436 from ember-cli/standard-pnpm
Browse files Browse the repository at this point in the history
stop using wyvox/action-setup-pnpm
  • Loading branch information
kategengler committed Feb 8, 2024
2 parents 31cf87a + bfc3866 commit fa85990
Show file tree
Hide file tree
Showing 4 changed files with 65 additions and 25 deletions.
25 changes: 12 additions & 13 deletions blueprints/addon/files/.github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ jobs:

steps:
- uses: actions/checkout@v3<% if (pnpm) { %>
- uses: wyvox/action-setup-pnpm@v2
- uses: pnpm/action-setup@v2
with:
node-version: 18<% } else { %>
version: 8<% } %>
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18
cache: <%= yarn ? 'yarn' : 'npm' %>
cache: <%= pnpm ? 'pnpm' : yarn ? 'yarn' : 'npm' %>
- name: Install Dependencies
run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>
run: <%= pnpm ? 'pnpm install --frozen-lockfile' : yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %>
- name: Lint
run: <%= pnpm ? 'pnpm' : yarn ? 'yarn' : 'npm run' %> lint
- name: Run Tests
Expand All @@ -41,16 +41,15 @@ jobs:

steps:
- uses: actions/checkout@v3<% if (pnpm) { %>
- uses: wyvox/action-setup-pnpm@v2
- uses: pnpm/action-setup@v2
with:
node-version: 18
args: '--no-lockfile'<% } else { %>
version: 8<% } %>
- uses: actions/setup-node@v3
with:
node-version: 18
cache: <%= yarn ? 'yarn' : 'npm' %>
cache: <%= pnpm ? 'pnpm' : yarn ? 'yarn' : 'npm' %>
- name: Install Dependencies
run: <%= yarn ? 'yarn install --no-lockfile' : 'npm install --no-shrinkwrap' %><% } %>
run: <%= pnpm ? 'pnpm install --no-lockfile' : yarn ? 'yarn install --no-lockfile' : 'npm install --no-shrinkwrap' %>
- name: Run Tests
run: <%= pnpm ? 'pnpm' : yarn ? 'yarn' : 'npm run' %> test:ember

Expand All @@ -74,15 +73,15 @@ jobs:

steps:
- uses: actions/checkout@v3<% if (pnpm) { %>
- uses: wyvox/action-setup-pnpm@v2
- uses: pnpm/action-setup@v2
with:
node-version: 18<% } else { %>
version: 8<% } %>
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18
cache: <%= yarn ? 'yarn' : 'npm' %>
cache: <%= pnpm ? 'pnpm' : yarn ? 'yarn' : 'npm' %>
- name: Install Dependencies
run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>
run: <%= pnpm ? 'pnpm install --frozen-lockfile' : yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %>
- name: Run Tests
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
16 changes: 10 additions & 6 deletions blueprints/app/files/.github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,16 @@ jobs:

steps:
- uses: actions/checkout@v3<% if (pnpm) { %>
- uses: wyvox/action-setup-pnpm@v2<% } else { %>
- uses: pnpm/action-setup@v2
with:
version: 8<% } %>
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18
cache: <%= yarn ? 'yarn' : 'npm' %>
cache: <%= pnpm ? 'pnpm' : yarn ? 'yarn' : 'npm' %>
- name: Install Dependencies
run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>
run: <%= pnpm ? 'pnpm install --frozen-lockfile' : yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %>
- name: Lint
run: <%= pnpm ? 'pnpm' : yarn ? 'yarn' : 'npm run' %> lint

Expand All @@ -37,13 +39,15 @@ jobs:

steps:
- uses: actions/checkout@v3<% if (pnpm) { %>
- uses: wyvox/action-setup-pnpm@v2<% } else { %>
- uses: pnpm/action-setup@v2
with:
version: 8<% } %>
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18
cache: <%= yarn ? 'yarn' : 'npm' %>
cache: <%= pnpm ? 'pnpm' : yarn ? 'yarn' : 'npm' %>
- name: Install Dependencies
run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>
run: <%= pnpm ? 'pnpm install --frozen-lockfile' : yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %>
- name: Run Tests
run: <%= pnpm ? 'pnpm' : yarn ? 'yarn' : 'npm' %> test
27 changes: 23 additions & 4 deletions tests/fixtures/addon/pnpm/.github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,16 @@ jobs:

steps:
- uses: actions/checkout@v3
- uses: wyvox/action-setup-pnpm@v2
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18
cache: pnpm
- name: Install Dependencies
run: pnpm install --frozen-lockfile
- name: Lint
run: pnpm lint
- name: Run Tests
Expand All @@ -34,10 +41,15 @@ jobs:

steps:
- uses: actions/checkout@v3
- uses: wyvox/action-setup-pnpm@v2
- uses: pnpm/action-setup@v2
with:
version: 8
- uses: actions/setup-node@v3
with:
node-version: 18
args: '--no-lockfile'
cache: pnpm
- name: Install Dependencies
run: pnpm install --no-lockfile
- name: Run Tests
run: pnpm test:ember

Expand All @@ -61,8 +73,15 @@ jobs:

steps:
- uses: actions/checkout@v3
- uses: wyvox/action-setup-pnpm@v2
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18
cache: pnpm
- name: Install Dependencies
run: pnpm install --frozen-lockfile
- name: Run Tests
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
22 changes: 20 additions & 2 deletions tests/fixtures/app/pnpm/.github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@ jobs:

steps:
- uses: actions/checkout@v3
- uses: wyvox/action-setup-pnpm@v2
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18
cache: pnpm
- name: Install Dependencies
run: pnpm install --frozen-lockfile
- name: Lint
run: pnpm lint

Expand All @@ -30,6 +39,15 @@ jobs:

steps:
- uses: actions/checkout@v3
- uses: wyvox/action-setup-pnpm@v2
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18
cache: pnpm
- name: Install Dependencies
run: pnpm install --frozen-lockfile
- name: Run Tests
run: pnpm test

0 comments on commit fa85990

Please sign in to comment.