Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating a new project on Node 14 with ember-cli 4.12 with yarn and typescript fails #10301

Open
kategengler opened this issue Jun 29, 2023 · 2 comments

Comments

@kategengler
Copy link
Member

CI failed on the lts-4-12 branch https://github.com/ember-cli/ember-cli/actions/runs/5406981956/jobs/9824464495

This exposed that generating a new project with yarn and typescript on Node 14 currently fails, due to dependencies of packages installed by ember-cli-typescript having engines.

Workarounds:

  • Use a newer node version
  • When generating the project errors, cd into the generated project and run the yarn add command that errored (should be printed to console), but with --ignore-engines. Any yarn command you run going forward will need --ignore-engines)
  • Find the correct older versions of the @types/ember* packages to install that do not depend on the newer version of @ember/test-helpers that has the engines updated.
@locks
Copy link
Contributor

locks commented Jul 24, 2023

Node 14 is EOL since May, can we assume people will be or will move to 16? 😅

@ef4
Copy link
Contributor

ef4 commented Jul 25, 2023

I think it's worth skipping these tests on that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants