Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ignore files in app and addon blueprints #10063

Closed
bertdeblock opened this issue Oct 25, 2022 · 0 comments · Fixed by #10229
Closed

Clean up ignore files in app and addon blueprints #10063

bertdeblock opened this issue Oct 25, 2022 · 0 comments · Fixed by #10229

Comments

@bertdeblock
Copy link
Contributor

Files included:

  • .eslintignore
  • .gitignore
  • .prettierignore

Some "issues" I've noticed:

  • All ignore files in an app contain ember-try related ignores even though we don't ship ember-try for apps
  • These files still include /bower_components/ - even though ember-cli still supports Bower, I don't think we should include this for new apps and addons
  • Same goes for /vendor/ - the vendor folder was recently removed here: [ENHANCEMENT] Remove vendor folder from app blueprint #10050
  • Is including /node_modules/ in .eslintignore and .prettierignore even needed nowadays? I thought this folder was ignored by default by those tools
  • Do we need to include /coverage/? Apps and addons don't ship with anything OOTB that generates a coverage folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CLEANUP] Update blueprint ignore files bertdeblock/ember-cli
1 participant
@bertdeblock