Skip to content

Commit

Permalink
Ensure ember-classic ember-try scenario uses Ember 3.x
Browse files Browse the repository at this point in the history
As we approach Ember 4.0.0, we need to help addons ensure that they only
test ember-classic's set of optional features when running under 3.x.

This updates the default ember-try config to hard code the
`ember-classic` scenario to Ember 3.28 (the last 3.x Ember version).
  • Loading branch information
rwjblue committed Oct 6, 2021
1 parent 49f89c6 commit de9ef67
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 0 deletions.
5 changes: 5 additions & 0 deletions blueprints/addon/files/addon-config/ember-try.js
Expand Up @@ -62,6 +62,11 @@ module.exports = async function () {
},
{
name: 'ember-classic',
npm: {
devDependencies: {
'ember-source': '~3.28.0',
},
},
env: {
EMBER_OPTIONAL_FEATURES: JSON.stringify({
'application-template-wrapper': true,
Expand Down
5 changes: 5 additions & 0 deletions tests/fixtures/addon/defaults/config/ember-try.js
Expand Up @@ -61,6 +61,11 @@ module.exports = async function () {
},
{
name: 'ember-classic',
npm: {
devDependencies: {
'ember-source': '~3.28.0',
},
},
env: {
EMBER_OPTIONAL_FEATURES: JSON.stringify({
'application-template-wrapper': true,
Expand Down
5 changes: 5 additions & 0 deletions tests/fixtures/addon/yarn/config/ember-try.js
Expand Up @@ -62,6 +62,11 @@ module.exports = async function () {
},
{
name: 'ember-classic',
npm: {
devDependencies: {
'ember-source': '~3.28.0',
},
},
env: {
EMBER_OPTIONAL_FEATURES: JSON.stringify({
'application-template-wrapper': true,
Expand Down

0 comments on commit de9ef67

Please sign in to comment.