Skip to content

Commit

Permalink
Replace eslint-plugin-node with eslint-plugin-n in the blueprints
Browse files Browse the repository at this point in the history 
eslint-plugin-node has been unmaintained for a long while and the ecosystem is switching to eslint-plugin-n, which is a fork of the original package that is being maintained by the community.
  • Loading branch information
@Windvis
Windvis committed Oct 31, 2022
1 parent b075b2e commit 500c824
Show file tree
Hide file tree
Showing 22 changed files with 37 additions and 44 deletions.
9 changes: 4 additions & 5 deletions blueprints/app/files/.eslintrc.js
View file
Expand Up @@ -52,12 +52,11 @@ module.exports = {
browser: false,
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],<% if (blueprint === 'app') {%>
extends: ['plugin:n/recommended'],<% if (blueprint === 'app') {%>
rules: {
// this can be removed once the following is fixed
// https://github.com/mysticatea/eslint-plugin-node/issues/77
'node/no-unpublished-require': 'off',
// this can be removed once the following PR is merged
// https://github.com/eslint-community/eslint-plugin-n/pull/57
'n/no-unpublished-require': 'off',
},<% } %>
},
{
Expand Down
2 changes: 1 addition & 1 deletion blueprints/app/files/package.json
View file
Expand Up @@ -57,7 +57,7 @@
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^11.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-qunit": "^7.3.1",
"loader.js": "^4.7.0",
Expand Down
3 changes: 1 addition & 2 deletions tests/fixtures/addon/.eslintrc.js
View file
Expand Up @@ -41,8 +41,7 @@ module.exports = {
browser: false,
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
extends: ['plugin:n/recommended'],
},
{
// test files
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/addon/defaults-travis/package.json
View file
Expand Up @@ -56,7 +56,7 @@
"eslint": "^7.27.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-ember": "^10.4.2",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^3.4.0",
"eslint-plugin-qunit": "^7.0.0",
"loader.js": "^4.7.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/addon/defaults/package.json
View file
Expand Up @@ -55,7 +55,7 @@
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^11.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-qunit": "^7.3.1",
"loader.js": "^4.7.0",
Expand Down
3 changes: 1 addition & 2 deletions tests/fixtures/addon/typescript/.eslintrc.js
View file
Expand Up @@ -43,8 +43,7 @@ module.exports = {
browser: false,
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
extends: ['plugin:n/recommended'],
},
{
// test files
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/addon/yarn/package.json
View file
Expand Up @@ -56,7 +56,7 @@
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^11.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-qunit": "^7.3.1",
"loader.js": "^4.7.0",
Expand Down
9 changes: 4 additions & 5 deletions tests/fixtures/app/.eslintrc.js
View file
Expand Up @@ -41,12 +41,11 @@ module.exports = {
browser: false,
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
extends: ['plugin:n/recommended'],
rules: {
// this can be removed once the following is fixed
// https://github.com/mysticatea/eslint-plugin-node/issues/77
'node/no-unpublished-require': 'off',
// this can be removed once the following PR is merged
// https://github.com/eslint-community/eslint-plugin-n/pull/57
'n/no-unpublished-require': 'off',
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/app/defaults/package.json
View file
Expand Up @@ -51,7 +51,7 @@
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^11.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-qunit": "^7.3.1",
"loader.js": "^4.7.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/app/embroider-no-welcome/package.json
View file
Expand Up @@ -53,7 +53,7 @@
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^11.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-qunit": "^7.3.1",
"loader.js": "^4.7.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/app/embroider-yarn/package.json
View file
Expand Up @@ -54,7 +54,7 @@
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^11.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-qunit": "^7.3.1",
"loader.js": "^4.7.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/app/embroider/package.json
View file
Expand Up @@ -54,7 +54,7 @@
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^11.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-qunit": "^7.3.1",
"loader.js": "^4.7.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/app/nested-project/actual-project/package.json
View file
Expand Up @@ -51,7 +51,7 @@
"eslint": "^7.24.0",
"eslint-config-prettier": "^8.1.0",
"eslint-plugin-ember": "^10.3.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^3.3.1",
"eslint-plugin-qunit": "^7.0.0",
"loader.js": "^4.7.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/app/npm-travis/package.json
View file
Expand Up @@ -51,7 +51,7 @@
"eslint": "^7.27.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-ember": "^10.4.2",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^3.4.0",
"eslint-plugin-qunit": "^7.0.0",
"loader.js": "^4.7.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/app/npm/package.json
View file
Expand Up @@ -50,7 +50,7 @@
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^11.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-qunit": "^7.3.1",
"loader.js": "^4.7.0",
Expand Down
9 changes: 4 additions & 5 deletions tests/fixtures/app/typescript-embroider/.eslintrc.js
View file
Expand Up @@ -43,12 +43,11 @@ module.exports = {
browser: false,
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
extends: ['plugin:n/recommended'],
rules: {
// this can be removed once the following is fixed
// https://github.com/mysticatea/eslint-plugin-node/issues/77
'node/no-unpublished-require': 'off',
// this can be removed once the following PR is merged
// https://github.com/eslint-community/eslint-plugin-n/pull/57
'n/no-unpublished-require': 'off',
},
},
{
Expand Down
9 changes: 4 additions & 5 deletions tests/fixtures/app/typescript/.eslintrc.js
View file
Expand Up @@ -43,12 +43,11 @@ module.exports = {
browser: false,
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
extends: ['plugin:n/recommended'],
rules: {
// this can be removed once the following is fixed
// https://github.com/mysticatea/eslint-plugin-node/issues/77
'node/no-unpublished-require': 'off',
// this can be removed once the following PR is merged
// https://github.com/eslint-community/eslint-plugin-n/pull/57
'n/no-unpublished-require': 'off',
},
},
{
Expand Down
9 changes: 4 additions & 5 deletions tests/fixtures/app/with-blueprint-override-lint-fail/.eslintrc.js
View file
Expand Up @@ -41,12 +41,11 @@ module.exports = {
browser: false,
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
extends: ['plugin:n/recommended'],
rules: {
// this can be removed once the following is fixed
// https://github.com/mysticatea/eslint-plugin-node/issues/77
'node/no-unpublished-require': 'off',
// this can be removed once the following PR is merged
// https://github.com/eslint-community/eslint-plugin-n/pull/57
'n/no-unpublished-require': 'off',
},
},
],
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/app/with-blueprint-override-lint-fail/package.json
View file
Expand Up @@ -51,7 +51,7 @@
"eslint": "^7.20.0",
"eslint-config-prettier": "^7.2.0",
"eslint-plugin-ember": "^10.2.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^3.3.1",
"loader.js": "^4.7.0",
"prettier": "^2.2.1",
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/app/yarn-travis/package.json
View file
Expand Up @@ -52,7 +52,7 @@
"eslint": "^7.27.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-ember": "^10.4.2",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^3.4.0",
"eslint-plugin-qunit": "^7.0.0",
"loader.js": "^4.7.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/app/yarn/package.json
View file
Expand Up @@ -51,7 +51,7 @@
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^11.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^15.3.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-qunit": "^7.3.1",
"loader.js": "^4.7.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/blueprints/addon-test.js
View file
Expand Up @@ -163,7 +163,7 @@ describe('blueprint - addon', function () {
);

let json = JSON.parse(output);
delete json.devDependencies['eslint-plugin-node'];
delete json.devDependencies['eslint-plugin-n'];
delete json.devDependencies['ember-try'];
delete json.devDependencies['ember-source-channel-url'];
delete json.devDependencies['@embroider/test-setup'];
Expand Down

0 comments on commit 500c824

Please sign in to comment.