Merge pull request #10110 from SergeAstapov/rfc-812

[RFC 812] Add `tracked-built-ins` dependency to app blueprint
ember-cli · Dec 13, 2022 · 1efaea3 · 1efaea3
2 parents eb19f6a + 3b66341
commit 1efaea3
Show file tree

Hide file tree

Showing 11 changed files with 17 additions and 3 deletions.
diff --git a/blueprints/addon/index.js b/blueprints/addon/index.js
@@ -70,6 +70,10 @@ module.exports = {
     // @see https://github.com/emberjs/rfcs/blob/master/text/0811-element-modifiers.md#detailed-design
     delete contents.devDependencies['ember-modifier'];
 
+    // Per RFC #812, addons should not have this dependency.
+    // @see https://github.com/emberjs/rfcs/blob/master/text/0812-tracked-built-ins.md#detailed-design
+    delete contents.devDependencies['tracked-built-ins'];
+
     // 100% of addons don't need ember-cli-app-version, make it opt-in instead
     delete contents.devDependencies['ember-cli-app-version'];
 

diff --git a/blueprints/app/files/package.json b/blueprints/app/files/package.json
@@ -65,6 +65,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {

diff --git a/tests/fixtures/app/defaults/package.json b/tests/fixtures/app/defaults/package.json
@@ -59,6 +59,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {

diff --git a/tests/fixtures/app/embroider-no-welcome/package.json b/tests/fixtures/app/embroider-no-welcome/package.json
@@ -61,6 +61,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {

diff --git a/tests/fixtures/app/embroider-yarn/package.json b/tests/fixtures/app/embroider-yarn/package.json
@@ -62,6 +62,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {

diff --git a/tests/fixtures/app/embroider/package.json b/tests/fixtures/app/embroider/package.json
@@ -62,6 +62,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {

diff --git a/tests/fixtures/app/npm-travis/package.json b/tests/fixtures/app/npm-travis/package.json
@@ -58,7 +58,8 @@
     "loader.js": "^4.7.0",
     "prettier": "^2.3.0",
     "qunit": "^2.15.0",
-    "qunit-dom": "^1.6.0"
+    "qunit-dom": "^1.6.0",
+    "tracked-built-ins": "^3.1.0"
   },
   "engines": {
     "node": "14.* || 16.* || >= 18"

diff --git a/tests/fixtures/app/npm/package.json b/tests/fixtures/app/npm/package.json
@@ -58,6 +58,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {

diff --git a/tests/fixtures/app/with-blueprint-override-lint-fail/package.json b/tests/fixtures/app/with-blueprint-override-lint-fail/package.json
@@ -57,7 +57,8 @@
     "loader.js": "^4.7.0",
     "prettier": "^2.2.1",
     "qunit": "^2.14.1",
-    "qunit-dom": "^1.6.0"
+    "qunit-dom": "^1.6.0",
+    "tracked-built-ins": "^3.1.0"
   },
   "engines": {
     "node": "14.* || 16.* || >= 18"

diff --git a/tests/fixtures/app/yarn-travis/package.json b/tests/fixtures/app/yarn-travis/package.json
@@ -59,7 +59,8 @@
     "loader.js": "^4.7.0",
     "prettier": "^2.3.0",
     "qunit": "^2.15.0",
-    "qunit-dom": "^1.6.0"
+    "qunit-dom": "^1.6.0",
+    "tracked-built-ins": "^3.1.0"
   },
   "engines": {
     "node": "14.* || 16.* || >= 18"

diff --git a/tests/fixtures/app/yarn/package.json b/tests/fixtures/app/yarn/package.json
@@ -59,6 +59,7 @@
     "prettier": "^2.8.1",
     "qunit": "^2.19.3",
     "qunit-dom": "^2.0.0",
+    "tracked-built-ins": "^3.1.0",
     "webpack": "^5.75.0"
   },
   "engines": {