Skip to content

Commit

Permalink
Merge pull request #10025 from bertdeblock/update-npm-version-constra…
Browse files Browse the repository at this point in the history
…ints

[ENHANCEMENT] Update NPM version constraints
  • Loading branch information
bertdeblock committed Sep 27, 2022
2 parents f57b7ea + 7d0666b commit 1adb237
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/tasks/npm-task.js
Expand Up @@ -26,7 +26,7 @@ class NpmTask extends Task {
// The command to run: can be 'install' or 'uninstall'
this.command = '';

this.versionConstraints = '3 || 4 || 5 || 6';
this.versionConstraints = '3 || 4 || 5 || 6 || 7 || 8';
}

get packageManagerOutputName() {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/tasks/npm-task-test.js
Expand Up @@ -25,7 +25,7 @@ describe('NpmTask', function () {
});

it('resolves with warning when a newer version is found', async function () {
td.when(task.npm(['--version'])).thenResolve({ stdout: '7.0.0' });
td.when(task.npm(['--version'])).thenResolve({ stdout: '9.0.0' });

await task.checkNpmVersion();
expect(ui.output).to.contain('WARNING');
Expand Down

0 comments on commit 1adb237

Please sign in to comment.