Avoid registering babel-plugin-ember-template-compilation repeatedly
#747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreeman
force-pushed
the
prevent-duplicate-babel-plugins
branch
from
04d3e5f
to
008b8d5
Compare
|
@rwjblue any chance you'll have time this week to give this one a look? Not the end of the world if not, just planning 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking at upgrading an app to Ember 3.28, and am running into issues where
babel-plugin-ember-template-compilationis being registered multiple times.It looks like the
isInlinePrecompileBabelPluginRegisteredutility function here is meant to act as a generic "have we already installed our plugin" guard, but it wasn't updated when the new Babel plugin was introduced for the post-modules-polyfill world.Based on @nightire's comment on #297 (comment), I wonder if this might be what they're running into as well? Our app also has
ember-enginesas a dependency, and I've confirmed locally that this change eliminates the "duplicate Babel plugin" error I was seeing.