This repository has been archived by the owner on Feb 6, 2021. It is now read-only.
Deprecate ember-cli-htmlbars-inline-precompiler. #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also help us deal with the issues in ember-cli/ember-cli-htmlbars#312. |
rwjblue
force-pushed
the
deprecate-and-noop
branch
from
4c7737b
to
b092ad2
Compare
rwjblue
force-pushed
the
deprecate-and-noop
branch
from
b092ad2
to
25ff873
Compare
ember-cli-htmlbars@4.0.3+ emits a helpful deprecation message when it detects that ember-cli-htmlbars-inline-precompile is present. This adds a deprecation notice to the README.md, and ensures that this packages `included` hook does nothing when using ember-cli-htmlbars@4.0.2 or higher.
rwjblue
force-pushed
the
deprecate-and-noop
branch
from
25ff873
to
d3a4f4a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-cli-htmlbars@4.0.3and higher emits a helpful deprecation message when it detects thatember-cli-htmlbars-inline-precompileis present.This adds a deprecation notice to the
README.md, and ensures that this addonsincludedhook does nothing when usingember-cli-htmlbars@4.0.3or higher.Closes #298