Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSP: refactor to not require style-src 'unsafe-inline and add test coverage #746

Merged
merged 11 commits into from
Jan 17, 2019
Merged

CSP: refactor to not require style-src 'unsafe-inline and add test coverage #746

merged 11 commits into from
Jan 17, 2019

Commits on Jan 16, 2019

  1. tests should ensure that library does not violate strict CSP

    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    81a2041 View commit details
    Browse the repository at this point in the history

  2. fix(Progress): should not violate CSP style-src 'none'

    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    fe26da3 View commit details
    Browse the repository at this point in the history

  3. fix(Collapse): should not violate CSP style-src 'none'

    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    6ea055e View commit details
    Browse the repository at this point in the history

  4. fix(Popover): test should not violate CSP style-src 'none'

    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    3174419 View commit details
    Browse the repository at this point in the history

  5. refactor logic to insert CSS rules for testing

    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    1e39704 View commit details
    Browse the repository at this point in the history

  6. fix(Tooltip): test should not violate CSP style-src 'none'

    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    5572b4b View commit details
    Browse the repository at this point in the history

  7. whitelist frame-src https://ghbtns.com/ used in application template … 

    …of dummy app
    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    a322869 View commit details
    Browse the repository at this point in the history

  8. relax CSP to allow expected iframe and bootstrap inline svg 

    Also should not apply CSP two times (by header and meta tag).
Report-Only for development, block violations in tests.
    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    8ee056c View commit details
    Browse the repository at this point in the history

  9. refactor(Popover): test should have styles before rendering

    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    04ba43b View commit details
    Browse the repository at this point in the history

  10. fix: use stylesheet.deleteRule() which is covered by spec 

    stylesheet.removeRule() is not part of spec. It's working in Chrome but not
in Firefox.
    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    f5b1914 View commit details
    Browse the repository at this point in the history

  11. test should fail if violating CSP

    @jelhan
    jelhan committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    ab3955f View commit details
    Browse the repository at this point in the history