Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve yielded components #698

Merged

Conversation

lougreenwood
Copy link
Contributor

@lougreenwood lougreenwood commented Nov 6, 2018

Follows on from #685

This PR allows overriding the remaining ember-bootstrap components.

This allows a user to extend any ember-bootstrap component and override the default bs-* components yielded out with their own extended implementations.

This PR omits work on bs-modal-simple.

A side effect of this PR is that ember-bootstrap should now "theoretically" be compatible with the upcoming MU structure where file-system nested components are not allowed :)

@simonihmig
Copy link
Contributor

Thank you! I'll merge a bit later, wanted to figure something different out before...

A side effect of this PR is that ember-bootstrap should now "theoretically" be compatible with the upcoming MU structure where file-system nested components are not allowed :)

What makes you think that? Or better, what makes you think that the current version does not support MU?

I have been using this addon in a MU app, and works fine so far (except for #648): I think there could be an issue with MU if you directly accessed nested components. But here you only directly use root-level components, all the nested ones are yielded (like "private" components, which are supported by MU). Also not sure if that is true when you use the fallback resolver, which is needed AFAIK to support "classic" addons...

@lougreenwood
Copy link
Contributor Author

I suppose you're right, there's actually 2 different PRs to remove any references to nested components (rather than this PR):

@lougreenwood
Copy link
Contributor Author

@simonihmig any news on the merge? I have a couple of other PRs which I'd like to submit which rely on this in master

@simonihmig simonihmig merged commit 10a73e4 into ember-bootstrap:master Nov 8, 2018
@simonihmig
Copy link
Contributor

Ok, merged!

@lougreenwood
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants