Upgrade addon to Ember 3.11 series #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanhammond I would love to get your review on this. I realize the PR is large, however much of it is noise if you consider what changes ember-cli-update makes. The important stuff to call out is called out in the PR description. Let me know if you want to discuss further! |
patcoll
changed the title
routeName reference, Upgrade addon to Ember 3.11
patcoll
force-pushed
the
finish-ember-311-upgrade
branch
from
8924b5d
to
febbfd5
Compare
- Qualify error to better assert it
patcoll
force-pushed
the
finish-ember-311-upgrade
branch
from
9082ba1
to
b5537a5
Compare
|
@nathanhammond @patcoll Is there an intention to upgrade the add-on? |
|
@NBallaney Not sure. I'll ping Nathan again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included:
no-outlet-outside-routesexception for template lintember/no-observersexception for ESLintAll tests pass in all scenarios for Ember 1.10 and up.