Clean up types with conditional return types

emahorvat52 · Jan 18, 2023 · d15f470 · d15f470
1 parent f009a23
commit d15f470
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/src/Composer/Factory.php b/src/Composer/Factory.php
@@ -283,6 +283,7 @@ public static function createOutput(): ConsoleOutput
      * @throws \InvalidArgumentException
      * @throws \UnexpectedValueException
      * @return Composer|PartialComposer Composer if $fullLoad is true, otherwise PartialComposer
+     * @phpstan-return ($fullLoad is true ? Composer : PartialComposer)
      */
     public function createComposer(IOInterface $io, $localConfig = null, bool $disablePlugins = false, ?string $cwd = null, bool $fullLoad = true, bool $disableScripts = false)
     {
@@ -446,10 +447,7 @@ public static function createGlobal(IOInterface $io, bool $disablePlugins = fals
     {
         $factory = new static();
 
-        $composer = $factory->createGlobalComposer($io, static::createConfig($io), $disablePlugins, $disableScripts, true);
-        assert(null === $composer || $composer instanceof Composer);
-
-        return $composer;
+        return $factory->createGlobalComposer($io, static::createConfig($io), $disablePlugins, $disableScripts, true);
     }
 
     /**
@@ -470,6 +468,7 @@ protected function addLocalRepository(IOInterface $io, RepositoryManager $rm, st
 
     /**
      * @return PartialComposer|Composer|null By default PartialComposer, but Composer if $fullLoad is set to true
+     * @phpstan-return ($fullLoad is true ? Composer|null : PartialComposer|null)
      */
     protected function createGlobalComposer(IOInterface $io, Config $config, bool $disablePlugins, bool $disableScripts, bool $fullLoad = false): ?PartialComposer
     {
@@ -611,10 +610,7 @@ public static function create(IOInterface $io, $config = null, bool $disablePlug
     {
         $factory = new static();
 
-        $composer = $factory->createComposer($io, $config, $disablePlugins, null, true, $disableScripts);
-        assert($composer instanceof Composer);
-
-        return $composer;
+        return $factory->createComposer($io, $config, $disablePlugins, null, true, $disableScripts);
     }
 
     /**