Fix type error in ArchiverInterface::supports(), fixes composer#10702

emahorvat52 · Jan 18, 2023 · 706d48a · 706d48a
1 parent 296d7b4
commit 706d48a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Composer/Package/Archiver/ArchiverInterface.php b/src/Composer/Package/Archiver/ArchiverInterface.php
@@ -36,9 +36,9 @@ public function archive(string $sources, string $target, string $format, array $
      * Format supported by the archiver.
      *
      * @param string $format     The archive format
-     * @param string $sourceType The source type (git, svn, hg, etc.)
+     * @param ?string $sourceType The source type (git, svn, hg, etc.)
      *
      * @return bool true if the format is supported by the archiver
      */
-    public function supports(string $format, string $sourceType): bool;
+    public function supports(string $format, ?string $sourceType): bool;
 }
diff --git a/src/Composer/Package/Archiver/PharArchiver.php b/src/Composer/Package/Archiver/PharArchiver.php
@@ -97,7 +97,7 @@ public function archive(string $sources, string $target, string $format, array $
     /**
      * @inheritDoc
      */
-    public function supports(string $format, string $sourceType): bool
+    public function supports(string $format, ?string $sourceType): bool
     {
         return isset(static::$formats[$format]);
     }

diff --git a/src/Composer/Package/Archiver/ZipArchiver.php b/src/Composer/Package/Archiver/ZipArchiver.php
@@ -78,7 +78,7 @@ public function archive(string $sources, string $target, string $format, array $
     /**
      * @inheritDoc
      */
-    public function supports(string $format, string $sourceType): bool
+    public function supports(string $format, ?string $sourceType): bool
     {
         return isset(static::$formats[$format]) && $this->compressionAvailable();
     }