feat(fontlock): fontify ${} expressions inside backticks #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR now has some slight conflicts with git master. Can you resolve those? 🙂 |
|
Oh yea it's the test cases! Always a PITA. I'll fix it tomorrow. |
Fuco1
force-pushed
the
feature/fontify-backtick-expr
branch
from
7a4a15f
to
f3224c1
Compare
|
My god I didn't even realize it took me two years to resolve the merge conflicts :D I was just updating my local typescript.el version and rebased this branch since it was what I was using. Thanks for merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #48 until better parser support is implemented.
This is an 80/20 approach so complex expressions inside the
${}are fontified as if a simple variable token. It probably can be improved in further iterations.