-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update nuxt to v3.9.3 and vue 3.4.15 #2543
Closed
Closed
Changes from 4 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
185a255
chore: update nuxt to v3.9.0
userquin 8770688
Merge branch 'main' into userquin/chore-nuxt-3.9.0
userquin 36c79b5
chore: update lock file
userquin 2edbf58
chore: fix lint
userquin 9f3d168
Merge branch 'main' into userquin/chore-nuxt-3.9.0
userquin 24f8823
chore: remove optimized deps + add some plugin log
userquin a52546b
Merge branch 'main' into userquin/chore-nuxt-3.9.0
userquin b45b550
Merge branch 'main' into userquin/chore-nuxt-3.9.0
userquin e5804b9
chore: nuxt 3.9.3 and vue 3.4.15
userquin 7e48b07
chore: add $pwa stub, vue sfc complaining
userquin e560c10
chore: fix hydration miss match warnings
userquin 0481f54
chore: register $pwa stub, vue sfc complaining
userquin 0f01f7e
chore: fix error mutating data inside scope
userquin 5abad7a
chore: fix warning about deps
userquin 262ef35
chore: w-fit breaking item layout
userquin 6d6313e
chore: fix typecheck
userquin bf3bb5a
chore: fix hydration miss match, tool tip with ids
userquin aa5a9e0
chore: cleanup
userquin 19a1d05
chore: fix user effect scope error
userquin a6c6175
chore: replace computedEager with computed
userquin d16d874
chore: pin vitest for now
danielroe 5d0c4b0
chore: remove expect error
danielroe 84249b4
chore: remove warnings about ?? and left operand
userquin 3d5f10e
chore: cleanup
userquin f2722e1
Merge remote-tracking branch 'origin/userquin/chore-nuxt-3.9.0' into …
userquin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { | ||
currentLocales, | ||
datetimeFormats, | ||
numberFormats, | ||
pluralRules, | ||
} from './i18n' | ||
|
||
export default defineI18nConfig(() => { | ||
return { | ||
legacy: false, | ||
availableLocales: currentLocales.map(l => l.code), | ||
fallbackLocale: 'en-US', | ||
fallbackWarn: true, | ||
missingWarn: true, | ||
datetimeFormats, | ||
numberFormats, | ||
// eslint-disable-next-line @typescript-eslint/comma-dangle | ||
pluralRules | ||
} | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
declare module 'virtual:emoji-mart-lang-importer' { | ||
export default function(lang: string): Promise<any> | ||
export default function (lang: string): Promise<any> | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks like a problem on the compile-time schedule, and probably a regression from Nuxt with the ability to create dependency between modules..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any change here is more likely a change in Vite (as we upgraded from Vite 4 -> Vite 5 in v3.9).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included the list for testing (testing with current main and this PR on my local), I need to remove all entries, we only need focus trap for client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good idea to include most of these in the config. We're lazy loading a lot of dependencies and they aren't discovered by the scanner. Some will end up triggering a full-reload on cold start. We may merge a new strategy in Vite 5.1 that we can adopt and this will be even more important then (we will start getting warnings to add the deps to the config). See:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has anyone in the team tried running dev in a clean clone (main branch with Nuxt 3.8)? there are almost 10 page refresh even when scrolling on timeline
@patak-dev I'm going to activate Vite 5
{ server: { fs: cachedChecks: true } }
;)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@userquin see nuxt/nuxt#24196 (comment), there were issues in Nuxt 3.8 preventing the optimized deps cache to be used (so every startup was a cold start). This should be fixed in 3.9 (I imagine also in newer patches for 3.8?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to include also the new floating-vue v5.0.0 :fingers_crossed:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patak-dev I don't see any improvement activating
cachedChecks: true
on my laptop (with or without optimized deps, just a few ms, in both cases removing the.cache
folder):