Implement no-op support for Plug.Conn.Adapter.upgrade/3

elixir-plug · Oct 29, 2022 · 6d3725d · 6d3725d
1 parent d5b5403
commit 6d3725d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/plug/cowboy/conn.ex b/lib/plug/cowboy/conn.ex
@@ -90,6 +90,9 @@ defmodule Plug.Cowboy.Conn do
     :cowboy_req.inform(status, to_headers_map(headers), req)
   end
 
+  @impl true
+  def upgrade(_req, _protocol, _args), do: {:error, :not_supported}
+
   @impl true
   def push(req, path, headers) do
     opts =

diff --git a/test/plug/cowboy/conn_test.exs b/test/plug/cowboy/conn_test.exs
@@ -340,6 +340,16 @@ defmodule Plug.Cowboy.ConnTest do
              request(:get, "/inform")
   end
 
+  def upgrade_unsupported(conn) do
+    conn
+    |> upgrade_adapter(:unsupported, opt: :unsupported)
+  end
+
+  test "upgrade will not set the response" do
+    assert {500, _, body} = request(:get, "/upgrade_unsupported")
+    assert body =~ "upgrade to unsupported not supported by Plug.Cowboy.Conn"
+  end
+
   def push(conn) do
     conn
     |> push("/static/assets.css")