Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aggregating over * #3176

Merged

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Dec 2, 2019

This is done to provide similar API to Ecto.Query.API.count/0 as
counting over * is faster in some DB than counting over column, even
when column is NOT NULL and indexed.

Close #3175

This is done to provide similar API to `Ecto.Query.API.count/0` as
counting over `*` is faster in some DB than counting over column, even
when column is `NOT NULL` and indexed.

Close elixir-ecto#3175
@josevalim josevalim merged commit 70a9294 into elixir-ecto:master Dec 2, 2019
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

@hauleth hauleth deleted the feat/support-aggregation-on-star branch March 27, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing :* as a column name in the Repo.aggregate/{3,4}
2 participants