ply: remove unused base64 import #540
Conversation
| @@ -64,7 +64,6 @@ | |||
| import sys | |||
| import os.path | |||
| import inspect | |||
| import base64 | |||
There was a problem hiding this comment.
This change is in a dependency, so I'm not going to accept it, sorry.
There was a problem hiding this comment.
Hi @eliben Thanks for the review. I understand not touching dependencies.
I noticed this import has been removed in a version of the ply source code I just quickly glanced at. (Version 3.11) so maybe it makes more sense to update the bundled ply source.
Would it be much work/risk to update the ply source in pycparser? I could submit a PR if you want, but I’m not familiar enough with pycparser to do extensive tests on the code base.
There was a problem hiding this comment.
I'm not objecting to upgrading to ply 3.11, but this first requires a separate issue to be created. The commit history should be reviewed to see if any changes to ply were applied after the previous version upgrade
Spotted this when trying to minimize runtime dependencies from the standard library in a separate project. :)